[Bug fix] Read side computation of derived variables should not be triggered when data is stored #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
force-pushed
the
bug-derived-read
branch
from
9fd7429 to
fc83d96
Compare
eisenhauer
approved these changes
Jul 18, 2024
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Oct 23, 2024
…string (ornladios#4247) (cherry picked from commit b6242e8)
Merged
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Oct 23, 2024
…string (ornladios#4247) (cherry picked from commit b6242e8)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Oct 23, 2024
…string (ornladios#4247) (cherry picked from commit b6242e8)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Oct 24, 2024
…string (ornladios#4247) (cherry picked from commit b6242e8)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Oct 24, 2024
…string (ornladios#4247) (cherry picked from commit b6242e8)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Oct 24, 2024
…string (ornladios#4247) (cherry picked from commit b6242e8)
vicentebolea
added a commit
that referenced
this pull request
Oct 26, 2024
* release_210: (33 commits) Bump version to v2.10.2 Merge pull request #4379 from vicentebolea/increace-cmake-version-dep-blosc Fix missing int64_t definition (#4365) Merge pull request #4346 from anagainaru/memSelLayout Merge pull request #4343 from anagainaru/gpuSpan Compress the lossless part of MGARD data with Zstd. It was uncompressed until now. (#4339) Fix an issue when reading blocks in streaming mode, when some producers did not write any block to output. (#4332) Fix in python API: (#4331) Merge pull request #4303 from anagainaru/build-frontier Merge pull request #4293 from anagainaru/check_parser_lexer Derived variables of type StoreData should not record the expression string (#4247) Update ReadMe.md (#4243) Switch from ROCM_VERSION_MAJOR to HIP_VERSION_MAJOR (#4222) Merge pull request #4207 from anagainaru/hide-symbols Patch for when both xrootd and derived variables are activated (#4200) Add defines for BP3, BP4 and BP5 (#4191) Overload NdCopy instead of adding a new argument for the 2.10 release Revert "Backport #3759 to Release 2.10 branch. (cherry-picked from master branch #4340) (#4341)" Revert "Merge pull request #4189 from pnorbert/campaign-s3-support" ci,python: enable python win2022 serial build ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, adios2 calls
ApplyExpressionevery time there is a derived variable (which is identified by the expression string we encode in the name). However, for variables where we store data we do not want to recompute the values. The easiest fix is to not store the expression string for these variables (since in essence they are no longer derived variables).